Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum Windows SDK version to 10.0.17763.0 #2625

Closed
wants to merge 4 commits into from

Conversation

VMBindraban
Copy link

Fixes #2624

@VMBindraban VMBindraban requested a review from a team as a code owner November 29, 2023 09:29
@DmitriyKirakosyan
Copy link
Contributor

@VMBindraban , are you still interested in this PR?

@VMBindraban
Copy link
Author

We moved away from codepush a couple of weeks ago since it's being retired and there is no alternative setup yet.
This PR is still required for people that use codepush with react-native-windows.

@DmitriyKirakosyan
Copy link
Contributor

@VMBindraban, thanks for the update.

Did you test the changes when you prepared this PR? Do you remember why you removed the entire <PropertyGroup Label="Configuration"> section? Was it not needed?

@VMBindraban
Copy link
Author

I tested the changes at the time yes.

Regarding removal of the section, i don't remember why i removed it. I was using Visual studio 2022 at the time. (v143)
Visual Studio 2019 (V142) is now EOL.

@DmitriyKirakosyan
Copy link
Contributor

#2719 is merged. Closing this.
@VMBindraban thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React-native 0.72 requires higher minimum SDK version for windows.
3 participants